fix(recipes): fix NIM operator validation and demo script issues#483
Open
yuanchen8911 wants to merge 2 commits intoNVIDIA:mainfrom
Open
fix(recipes): fix NIM operator validation and demo script issues#483yuanchen8911 wants to merge 2 commits intoNVIDIA:mainfrom
yuanchen8911 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add k8s-nim-operator as a new AICR component and create an H100/EKS/Ubuntu inference recipe for NIM. This supports the CNCF AI Conformance submission where NIM on EKS is the certified product and AICR is the validation tooling. - Add `nim` platform type to recipe criteria with tests - Register k8s-nim-operator v3.1.0 in component registry with health check - Create h100-eks-ubuntu-inference-nim overlay with DRA support - Add NIMService workload manifest (Llama 3.2 1B) - Add NIM chat demo UI (nim-chat-server.sh, nim-chat.html) - Fix: load healthCheck.assertFile content in ApplyRegistryDefaults so deployment validation actually executes Chainsaw health checks Closes NVIDIA#473
yuanchen8911
force-pushed
the
feat/nim-operator-recipe
branch
from
3a60f3b to
4229287
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes to #478 (merged) addressing review findings:
Revert health check file loading —
ApplyRegistryDefaultswas loadinghealthCheck.assertFilecontent intoHealthCheckAsserts, which activated the chainsaw binary path inexpected-resources. The deployment validator image (distroless) doesn't include chainsaw, causing runtime failures for all recipes with health checks.Add
expectedResourcesfor NIM operator — Without the chainsaw path, the NIM operator had no deployment validation. AddedexpectedResourceswithDeployment/k8s-nim-operatorinnvidia-nimnamespace soexpected-resourcesverifies the operator is running.Fix demo script port handling —
nim-chat-server.shnow honorsAPI_PORT/UI_PORTenv var overrides, fails fast on port conflicts instead of killing unrelated processes, and detects port-forward failures before printing "Ready!".Test plan
go test -race ./pkg/recipe/...passesHealthCheckAssertsis NOT populated byApplyRegistryDefaultsexpectedResourcesvalidated on live EKS cluster with NIM operator deployed